JamenBenthe86 Posted October 2, 2024 Posted October 2, 2024 On the newest version, since the equipment slot filtering is removed, will the mod still detect bikini armor no matter the slot as long as it has the eroticarmor keyword?
Nuascura Posted October 2, 2024 Author Posted October 2, 2024 10 minutes ago, JamenBenthe86 said: On the newest version, since the equipment slot filtering is removed, will the mod still detect bikini armor no matter the slot as long as it has the eroticarmor keyword? yes
JamenBenthe86 Posted October 2, 2024 Posted October 2, 2024 18 minutes ago, Nuascura said: yes Thanks! Thanks for the great mod btw.
Nuascura Posted October 2, 2024 Author Posted October 2, 2024 3 hours ago, JamenBenthe86 said: Thanks! Thanks for the great mod btw. You're welcome! I hope you continue to enjoy it!
qualcheduna Posted October 2, 2024 Posted October 2, 2024 The removal of the slot filtering is kind of a bummer. Cause now to have a bikini armor set recognized I need to put the eroticarmor keyword on every piece piece, rigth? Like boots, gauntlets, pauldrons and stuff. That is not a problem per se (I can distribute it with KID easily) but then the other mods that look for the keyword (like Baka's group of mods) don't work right, e.g. full plate with "erotic" gauntlets being counted as naughty. Current version I am just filtering for 39 and 52 and everything works nicely. Why was it removed? For curiosity.
Nuascura Posted October 2, 2024 Author Posted October 2, 2024 (edited) 2 hours ago, qualcheduna said: Why was it removed? For curiosity. One of if not the only remaining script bloat that can be removed without severely compromising Licenses' feature set is slot filtering. The reason being that none of my current dependencies provide a good option to filter by a slot array as parameter. Ex. Form[] FilterByEquippedSlot(int[] slotArray) PO3E provides a function to grab all equipped items but doesn't allow filtering to exclude or only include items in select slots. PyramidUtils provides a function to grab all items in a container by a keyword but, again, not by slot. No combination of dependency use allows me to avoid having to iterate through slots with a While loop - and, oddly, each iteration/loop takes a very obvious and not insignificant amount of time; Papyrus doesn't provide any iteration alternatives, such as For loops. Then, couple this with no one responding when I proposed removing slot filtering and poof, there it went. You'll find the new method I implemented much faster and efficient, and less prone to any issues a While loop can cause. Also guards against 'cheaters' using mod armors populating unconventional slots + the less technically-inclined who can't properly adjust the slot array due to SkyUI's MCM text-entry character limits. IF someone implements the above function natively, I'll create a better interface to customize slot checks. --- As for the thing with Bikini Armors - if your items are properly tagged with Baka's dozens of SLA keywords, why not just add all of those keywords to the bikini keyword string array? Other items belonging to a bikini set but aren't "erotic" by themselves should have the "eroticarmor" keyword up to your own interpretation of how the Bikini License is enforced. Edited October 3, 2024 by Nuascura
IBAGadget Posted October 3, 2024 Posted October 3, 2024 1 hour ago, Nuascura said: As for the thing with Bikini Armors - if your items are properly tagged with Baka's dozens of SLA keywords, why not just add all of those keywords to the bikini keyword string array? Other items belonging to a bikini set but aren't "erotic" by themselves should have the "eroticarmor" keyword up to your own interpretation of how the Bikini License is enforced. I apply the EroticArmor keyword to the armor/clothing piece that is covering the chest and/or pelvis. They are really the only things that need it. LPO only needs to detect the keyword on a single item that you are wearing, not on everything. Who cares if you are wearing stripper heels if the rest of you is covered in full plate? Conversely, if you are wearing full plate everywhere, but only have a string with knots tied in it covering your nipples.......
qualcheduna Posted October 3, 2024 Posted October 3, 2024 (edited) I understand, it is for efficiency. I will remain on 1.18.3 for now. I'll see if I can ask one of the modders of the dependencies to implement the missing function. Asking them costs me nothing, at worse they say no or ignore me. 15 hours ago, Nuascura said: As for the thing with Bikini Armors - if your items are properly tagged with Baka's dozens of SLA keywords, why not just add all of those keywords to the bikini keyword string array? Other items belonging to a bikini set but aren't "erotic" by themselves should have the "eroticarmor" keyword up to your own interpretation of how the Bikini License is enforced. But some parts of armors like TAWOBA don't have keywords that make sense, like pauldrons for ex, so I do what IBAGadget said. Would you consider, as maybe a temporary thing, implementing a tickbox that makes so that one piece of equipment with the keyword makes the whole outfit count as bikini? Or maybe a configurable number of pieces, idk. I know that you could cheat but it is singleplayer, I already play with honor rules, I'd be cheating myself. Edited October 3, 2024 by qualcheduna
JamenBenthe86 Posted October 3, 2024 Posted October 3, 2024 License revocation could be a cool feature to add. Maybe if you have a bounty then your licenses are canceled, or maybe the guards will occasionally try to bully the player into a bribe, refusal of which could lead to them revoking a license.
LobsterCrab Posted October 3, 2024 Posted October 3, 2024 I'm getting force greeted for magic violations while I already have the nullify magicka debuff and tattoo (and not casting any spell or anything, just happens as soon as I load in). Not sure if there's some silent spell being applied from a different mod or something. This only seems to happen when I lose my magic license, it's normally fine when I don't own a license, but in this situation I buy a license, lose it through naked dungeons and then get these force greetings for casting magic before I can get my license back. I've attached a papyrus log of loading a save, getting immediately force greeted, and then quitting. Papyrus.0.log
Nuascura Posted October 3, 2024 Author Posted October 3, 2024 @qualcheduna No need to worry, I'm checking if Ponzi can implement the function. But if you do find such a function elsewhere, you're free to let me know! 3 hours ago, qualcheduna said: Would you consider, as maybe a temporary thing, implementing a tickbox that makes so that one piece of equipment with the keyword makes the whole outfit count as bikini? Or maybe a configurable number of pieces, idk. I know that you could cheat but it is singleplayer, I already play with honor rules, I'd be cheating myself. There's an argument for helping (or at least nudging) people and myself with self-control - but like you said, it's a single-player game, so I won't get too deep into that convo. I would try not to implement anything temporary to both ease save game upgrades for players and reduce the chance that I break anything from improper feature removal. Licenses is quite near a stable asymptote atm.
Nuascura Posted October 3, 2024 Author Posted October 3, 2024 @JamenBenthe86 Good ideas! But probs a little further in the future before I can consider them. Someone else might've introduced them as an add-on by then. @LobsterCrab You need to enable the "Log Traces" setting in Licenses' MCM Auxiliary tab. I don't see any useful outputs in your log atm.
47696c6573 Posted October 8, 2024 Posted October 8, 2024 (edited) On 10/2/2024 at 3:10 PM, Nuascura said: As for the thing with Bikini Armors - if your items are properly tagged with Baka's dozens of SLA keywords, why not just add all of those keywords to the bikini keyword string array? Other items belonging to a bikini set but aren't "erotic" by themselves should have the "eroticarmor" keyword up to your own interpretation of how the Bikini License is enforced. Have you considered add a dedicated keyword for the purpose of bikini license enforcement? This way all we have to do is distribute it to all the bikini armor and any other armor pieces we think shouldn't matter using KID, and it won't affect how erotic other mod thinks the piece is. Edited October 8, 2024 by 47696c6573
Nuascura Posted October 8, 2024 Author Posted October 8, 2024 1 hour ago, 47696c6573 said: Have you considered add a dedicated keyword for the purpose of bikini license enforcement? This way all we have to do is distribute it to all the bikini armor and any other armor pieces we think shouldn't matter using KID, and it won't affect how erotic other mod thinks the piece is. I forgor… I did think about it. I just never managed to get to it. I’ll be sure to implement this for the next update.
wareware Posted October 8, 2024 Posted October 8, 2024 Some suggestions/requests An ability to get non expiring licenses would be nice(and some more ways to lose them) Using VendorItem keywords to detect violations feels weird since even bikini armors will have them. There is a GetWeightClass function but I don't know how you can iterate it for checks like Keywords. Alternatively you can make it so that if you have a Bikini license your VendorItemArmor/Clothing gear wouldn't get confiscated as long as at least one piece of item you are wearing has the bikini keyword which should take a single WornHasKeyword.
Nuascura Posted October 8, 2024 Author Posted October 8, 2024 @wareware Permanent licenses are certainly on the docket! It's a little far in the future, but I do want to get there prudently and before I retire from modding. Licenses uses VendorItem keywords the way vanilla items treat them because items for trade are generally non-imperative or non-quest items. If there are any issues with mod items, it's on those mods or the user to fix them. If there was an equivalent keyword-function for GetWeightClass, that would've been perfect. Unfortunately, I couldn't find any. VendorItem was the closest in terms of single-keyword-use that covered a sufficient number of items (but sadly not all) and very secondarily excludes some quest items for pure convenience. WornHasKeyword is a good one. Unfortunately, it can't take an array as parameter, which returns me to why I removed slot filtering in the first place - Papyrus While loops are too slow for regular usage. I might be able to get a similar effect with PO3E + PyUtils, though. Thanks for the idea! @qualcheduna suggested it as well, and I think it might be the best path forward. It should serve as a good addition regardless of if slot filtering makes a comeback.
LobsterCrab Posted October 11, 2024 Posted October 11, 2024 On 10/4/2024 at 12:55 AM, Nuascura said: @LobsterCrab You need to enable the "Log Traces" setting in Licenses' MCM Auxiliary tab. I don't see any useful outputs in your log atm. Whoops, my bad lol. Should be enabled now in this log? Same situation. Papyrus.0.log
Nuascura Posted October 11, 2024 Author Posted October 11, 2024 7 minutes ago, LobsterCrab said: Whoops, my bad lol. Should be enabled now in this log? Same situation. Papyrus.0.log 334.57 kB · 1 download You're gonna have to redo your entire scenario because this log starts with the LPO bounty already running. If you have Log Traces enabled and logging the scenario where LPO checks your character for violation, then we'll be able to see exactly which MGEF form is triggering LPO.
Nuascura Posted October 13, 2024 Author Posted October 13, 2024 Happy weekend. A quick two reminders: If you'd like to push for a formal feature request, you're free to open a GitHub issue or open a pull request If you want immediate access to pre-releases, available content is hosted on my Patreon page (free access is possible; a Patreon account is necessary for security)
LynErso666 Posted October 14, 2024 Posted October 14, 2024 (edited) I really love the new update. It seems much faster than before, the enforcers are more responsive, 😊💕💕 so thanks a million but in no test playthrough have I ever seen the travel permit function properly. I start a new game, and every time I start in the Another Life cell, this mod will say Ive been reported missing once initialized. Weird. Doesn't matter where or when or how far through the play I am when I start. Its always that. Then I get busted by the first guard I see for no travel permit. (I only use that and armor and magic and curfew permits with Sexy Adventures doing other things) and it never occurs ever ever again for the rest of any playthroughs. It never even gives me a "You're detected in a settlement " notification unless I refresh the mod manually (because people randomly start enforcing licences I dont have enabled sometimes and I have to manually refresh it to make it work right again, even that's only happened in 2 or 3 100 save test playthroughs out of around 30) but the travel permit thing is definitely broke as hell. There is no combination of mods or features or tests in which the travel permit is enforced save for once at the start of a new game and then never EVER again. It just needs work hella badly. 😭😭 But you've built this mod up incredibly fast for how quick this mod appeared on the loverslab and it's just crazy how good it is regardless of the travel thing. 💕 Well done. But I've messed with it way too long now 😂 O the hours and hours and days messing with the settings and whatnot. I don't think im down for it again until the travel permit thing has been reworked, so definitely tracking for that. Thanks very much. Edited October 14, 2024 by LynErso666
IBAGadget Posted October 14, 2024 Posted October 14, 2024 1 hour ago, LynErso666 said: There is no combination of mods or features or tests in which the travel permit is enforced save for once at the start of a new game and then never EVER again. It just needs work hella badly. Strange. I've only ever had the 'no travel permit' enforcement at game start when AS-LAL puts me in one of the Hearthfire Homes (Heljarchen Hall, Winstad Manor, Lakeview Manor). If it puts me in one of the player homes in a settlement (Solitude, Whiterun, Windhelm, Riften, Markarth) I don't get flagged for no travel permit as I'm starting in a city. I did make the mistake of letting my travel permit expire while I was in Kynesgrove, and the guards immediately arrested me and tossed me in the Windhelm jail. I think you have something else that is messing with your LPO enforcement, as I've never had a problem with getting arrested when my permits run out. I'm also careful to keep track of when my permits are going to expire so that I am in a position to renew them before it becomes an issue. I also vary the times that they are valid for so that I don't get in a situation where they are all going to expire at the same time. Currently running version 1.18.2 Also only running with 577 Active mods on my SAE (version 1.6.640)
Nuascura Posted October 14, 2024 Author Posted October 14, 2024 (edited) @LynErso666 Haha, it has been a year. And unlike other modders, this is my primary project and I'm actually incentivized to keep this mod bug-free since I actively use it. Which brings me to my next point: Like IBAGadget, it is a little strange that the Travel Permit feature has never worked for you. I will say, the feature has had its ups and downs in terms of intended functionality since 1.12, but it should be fine with 1.19.0. I was able to iron out some issues when I released the 1.18.3 update. With 1.19.0, I've been wandering around Ivarstead and Whiterun city with no issues, with Worldspace Differentiation enabled. I encourage you to open a Bug Report on GitHub, which contains an issue template for you to follow. Otherwise, pass the following: A step-by-step process from the point of creating a new character An exported Settings.json A papyrus log (papyrus.0.log) that logs your issue replication process; make sure you've enabled Licenses' "Log Traces" function. Edited October 14, 2024 by Nuascura 1
LynErso666 Posted October 14, 2024 Posted October 14, 2024 1 hour ago, Nuascura said: @LynErso666 Haha, it has been a year. And unlike other modders, this is my primary project and I'm actually incentivized to keep this mod bug-free since I actively use it. Which brings me to my next point: Like IBAGadget, it is a little strange that the Travel Permit feature has never worked for you. I will say, the feature has had its ups and downs in terms of intended functionality since 1.12, but it should be fine with 1.19.0. I was able to iron out some issues when I released the 1.18.3 update. With 1.19.0, I've been wandering around Ivarstead and Whiterun city with no issues, with Worldspace Differentiation enabled. I encourage you to open a Bug Report on GitHub, which contains an issue template for you to follow. Otherwise, pass the following: A step-by-step process from the point of creating a new character An exported Settings.json A papyrus log (papyrus.0.log) that logs your issue replication process; make sure you've enabled Licenses' "Log Traces" function. Im good on all that 😆 but thanks very much. Good luck! 😊
gardelucina Posted October 19, 2024 Posted October 19, 2024 Is there any way to get this to affect NPCs as well? It'd be great if I, for example, enable the clothes license like for male or female, to see the poorer npcs be naked too.
LynErso666 Posted October 19, 2024 Posted October 19, 2024 Weirdly this mod works great but in every test playthrough I go thru, it alwayyyys breaks. Just randomly after some guard tries to chase me or some prison stay, guards are never ever again made enforcers, they never stop me for anything. All licenses become completely useless and nothing is enforced whatsoever. Stopping the whole mod and initializing again doesn't work, uninstalling and cleaning the save and reinstalling just starts a broken Licenses mod. It seems like this mod just has a very set in stone shelf life of how long it can last in a playthrough before it just completely crumbles.
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now