PAF Fixes and Addons

[Dg75]

53 minutes ago, emilHand said:

 

One last update, I tried installing 3.0.1 on a clean save, initializing, then saving, and updating to 3.0.7 which updated the MCM but seems to stall Actor behavior. I was unable to add new actors.

What do you mean Actor behavior ?

 

Test PFA 3.0.7 Initial Installation:

I just finished starting up new game left helgin, got to Riverwood then save exit.

-first I install Sexlab and Creature Framework, MoreNasty Creatues... the whole slew of prerequisites.

Loaded game and initialized those kind of mods first.

-second Install PFA_VoicePackMain(Comment Manager), Arousal, Slac, Pee and Fart, and all Paf's required mods

Loaded Game Initialized all those.

-Third Install Paf fixes and addons, my cm-evlyn voice, Dooty, Dooty patch...

Loaded and Initialized.

Everything loaded and fired right up for me. MCM took a few minuts to reg all these steps. OnSleepStop event Initialized, then went outside to take a dump.

Edited July 7, 2024 by Dg75

[Dg75]

Oops ! I had changed the names of the Dooty houses when I was testing. I meant to change them back.

Instead of seeing Outhouse, its reading Outhouse_1..2 . 3 

No biggy I'll fix them on next update.

[emilHand]

12 hours ago, Dg75 said:

What do you mean Actor behavior ?

 

Test PFA 3.0.7 Initial Installation:

I just finished starting up new game left helgin, got to Riverwood then save exit.

-first I install Sexlab and Creature Framework, MoreNasty Creatues... the whole slew of prerequisites.

Loaded game and initialized those kind of mods first.

-second Install PFA_VoicePackMain(Comment Manager), Arousal, Slac, Pee and Fart, and all Paf's required mods

Loaded Game Initialized all those.

-Third Install Paf fixes and addons, my cm-evlyn voice, Dooty, Dooty patch...

Loaded and Initialized.

Everything loaded and fired right up for me. MCM took a few minuts to reg all these steps. OnSleepStop event Initialized, then went outside to take a dump.

 

3 hours ago, Dg75 said:

Oops ! I had changed the names of the Dooty houses when I was testing. I meant to change them back.

Instead of seeing Outhouse, its reading Outhouse_1..2 . 3 

No biggy I'll fix them on next update.

 

Dooty patch still sems to work with the 3.0.1...I will probably need to roll with that for now until I can figure out my issue with subsequent updates.

 

And by actor behavior I was referring to NPCs. PAF continues to work with the player when updating to 3.0.7 but I cannot add an NPC to tracking or if I add an NPC and then update to 3.0.7 their needs change but they make no move to relieve themselves. 

Edited July 7, 2024 by emilHand

[emilHand]

54 minutes ago, emilHand said:

 

 

Dooty patch still sems to work with the 3.0.1...I will probably need to roll with that for now until I can figure out my issue with subsequent updates.

 

And by actor behavior I was referring to NPCs. PAF continues to work with the player when updating to 3.0.7 but I cannot add an NPC to tracking or if I add an NPC and then update to 3.0.7 their needs change but they make no move to relieve themselves. 

 

Just a thought but since I had some trouble loading 3.0.1 without Comment Manager despite no dependency I wonder if there is something different for VR that won't let me load it and subsequently maybe adding COBW when its ready will allow me to load new versions of PFA properly. What is COBW anyways or is that a secret? lol

[Dg75]

7 hours ago, emilHand said:

 

Just a thought but since I had some trouble loading 3.0.1 without Comment Manager despite no dependency I wonder if there is something different for VR that won't let me load it and subsequently maybe adding COBW when its ready will allow me to load new versions of PFA properly. What is COBW anyways or is that a secret? lol

COBW is a like a addon to pfa. It karma based on PFA's tracking system.

offers a prayer system to cleanse tainted soul, and point system for it.  Alt ways to level up..

Contrary can follow darkness and become BloodWhore Vampire that has an uncanny ability to birth a ginn(evil little buger) 

so much more..

 

When I tested 3.0.7, I tested with COBW disabled, and it gave me no problems.

You seem to be having mass difficulty with the scripts and quests. Maybe its a VR issue or system spec maybe ? Are you tethered or using PC's GPU ?

Maybe a Vram thing. Between PAF and PFA theirs a lot script. A weaker system may have issues

Further you should do some research and see if GetFormFromFile() function is compatible with VR. PFA uses the hell out that function,

and if that function fails you or if OnPlayerLoadGame event fails it will give you very similar issues you are getting.

 

If I was you I'd try just PAF without PFA and play around with it, make sure everything working on original PAF mod first. 

Then try install PFA 3.0.7 after PAF is fully initiated and all its quest oninit events fired up. Npc's added and cycled at least once..

PFA relies PAF Main Quest fully functional in order to run. The starter for PFA is PAF main quest's Player Alias. So if issues with PAF

expect issues with PFA

That old PFA 3.0.1 version had bugs and is bound to give you many issues.

Edited July 8, 2024 by Dg75

[emilHand]

9 hours ago, Dg75 said:

COBW is a like a addon to pfa. It karma based on PFA's tracking system.

offers a prayer system to cleanse tainted soul, and point system for it.  Alt ways to level up..

Contrary can follow darkness and become BloodWhore Vampire that has an uncanny ability to birth a ginn(evil little buger) 

so much more..

 

When I tested 3.0.7, I tested with COBW disabled, and it gave me no problems.

You seem to be having mass difficulty with the scripts and quests. Maybe its a VR issue or system spec maybe ? Are you tethered or using PC's GPU ?

Maybe a Vram thing. Between PAF and PFA theirs a lot script. A weaker system may have issues

Further you should do some research and see if GetFormFromFile() function is compatible with VR. PFA uses the hell out that function,

and if that function fails you or if OnPlayerLoadGame event fails it will give you very similar issues you are getting.

 

If I was you I'd try just PAF without PFA and play around with it, make sure everything working on original PAF mod first. 

Then try install PFA 3.0.7 after PAF is fully initiated and all its quest oninit events fired up. Npc's added and cycled at least once..

PFA relies PAF Main Quest fully functional in order to run. The starter for PFA is PAF main quest's Player Alias. So if issues with PAF

expect issues with PFA

That old PFA 3.0.1 version had bugs and is bound to give you many issues.

 

I'm using my PC's GPU which is an RTX 2080, older but not so much that I would expect issues. I used PAF by itself with out issue quite a bit prior to discovering PFA. I'll continue to tinker with it. I appreciate all the help and insight.

[Dg75]

1 hour ago, emilHand said:

 

I'm using my PC's GPU which is an RTX 2080, older but not so much that I would expect issues. I used PAF by itself with out issue quite a bit prior to discovering PFA. I'll continue to tinker with it. I appreciate all the help and insight.

2080 is better than my 2070 super, so you shouldn't have a problem their.

Something does come to mind though.  It maybe nothing but GetFormFromFile func has to return something, either the Form in question or a None.

it used to print an error to log if got None, but shouldn't cause issue. I think Po3 Papyrus Extender fixed the game so it no longer printed an error if it got None

IDk maybe you are getting issues if when it gets None. You could try if haven't done so turning Papyrus logging on in the Ini file see if anything useful pops up.

 

 

So what happens if GetFormFromFile() is broken or it returns a Null instead of None

in my code to initialize PFA: 

 

Note the line in the below code:

if  PFAComments != None && PFAComments.DAG_BWVersion.GetValue() >= CMVers

 

;CMVars starts with 3.00 value as its earliest compatible, but this not the issue.

;if GetFormFromFile returned Null instead of NONE... well Null is not a NONE two different things 

;so    && PFAComments.DAG_BWVersion.GetValue() >= CMVers only get read if PFAComments not = to None

;if so its trying to get  DAG_BWVersion GlobalVariable property from a Null

;PFAComments.DAG_BWVersion.GetValue(),  by all counts that would be Unhandled exception and probably a CDT or

;shit gets locked down and craps all over your papyrus log with errors.

;GetFormFromFile returns a form or if not found a None !  if it functions as intended, So what happens when using this function 

;on game 1.5.97 or on something all these crazy AE updates broke since 1.5.97, not sure but, that what I meant to make sure VR is 

;compatible with it. As far I know it is based off 1.5.97 se game scripts and supposedly a great many functions and events stop 

;working for 1.5.97 after the AE updates. includeing OnPlayerLoadGame event, not sure about GetFormFromFile though..

 

Event OnSleepStop(bool abInterrupted)
    if  !Initialized
        Initialized = True
        PFAComments = Game.GetFormFromFile(0x0005BBE7, "Comment_Manager.esp") as CM_Comments
        if  PFAComments != None && PFAComments.DAG_BWVersion.GetValue() >= CMVers
            if  PFAComments.DAG_BWVersion.GetValue() > CMVers
                CMVers = PFAComments.DAG_BWVersion.GetValue()
                Create_MaleVariant(True)
            else
                Create_MaleVariant()
            endif            
            PFA_PafComments.SetValue(1)            
            Arousal = Game.GetFormFromFile(0x0003FC36, "SexLabAroused.esm") As Faction  ;for sextalk feature
            PFAComments.Set_FutaArmor(SOSKW, Futa)
        else
            ;Debug.Notification("Comment Manager not found!")
            PFA_PafComments.SetValue(0)
            PFAComments = None
            Arousal = None
        endif
        if  !(PlayerRef.HasSpell(PFA_PafCellTracker))
            PlayerRef.AddSpell(PFA_PafCellTracker)
        endif
        COBWSystems = Game.GetFormFromFile(0x0002912F, "Curses of the BloodWhore.esp") as BW_COBWSystems
        if  COBWSystems != None
            if  !COBW
                COBW = True
                BloodLust = COBWSystems.DAG_BloodWhore
                Debug.Notification("Curses of the BloodWhore found")
            endif
        else
            COBW = False
            COBWSystems = None
            BloodLust = None
            Debug.Notification("COBW not found")
        endif
        PFA_PafCellTrackerMarker.Moveto(PlayerRef)
        ND_TimeStamp = GameDaysPassed.GetValue()
        Debug.Notification("Paf Fixes and Addons initialized!")
        Return
    endif

   ;other stuff to do here if its already been Initialized

EndEvent

Edited July 8, 2024 by Dg75

[Dg75]

23 hours ago, Dg75 said:

Oops ! I had changed the names of the Dooty houses when I was testing. I meant to change them back.

Instead of seeing Outhouse, its reading Outhouse_1..2 . 3 

No biggy I'll fix them on next update.

Uploaded PFA_DootyPatch-v3.0.7 which just fixes the nameing of the Outhouses you see when in your crosshairs. Didn't break anything it was just an eyesore..

instead of Outhouse_1 , they all should read just Outhouse

[Medieval Genie]

On the newest versions of PAF Fixes and Addons (3.0.7) and PFA VoicePack (3.0.6), I got:

 

"Unhandled exception "EXCEPTION_ACCESS_VIOLATION" at 0x7FF71B982EC0 SkyrimSE.exe+1422EC0    mov eax, [rdi+0x28]"

[emilHand]

On 7/8/2024 at 7:48 AM, Dg75 said:

2080 is better than my 2070 super, so you shouldn't have a problem their.

Something does come to mind though.  It maybe nothing but GetFormFromFile func has to return something, either the Form in question or a None.

it used to print an error to log if got None, but shouldn't cause issue. I think Po3 Papyrus Extender fixed the game so it no longer printed an error if it got None

IDk maybe you are getting issues if when it gets None. You could try if haven't done so turning Papyrus logging on in the Ini file see if anything useful pops up.

 

 

So what happens if GetFormFromFile() is broken or it returns a Null instead of None

in my code to initialize PFA: 

 

Note the line in the below code:

if  PFAComments != None && PFAComments.DAG_BWVersion.GetValue() >= CMVers

 

;CMVars starts with 3.00 value as its earliest compatible, but this not the issue.

;if GetFormFromFile returned Null instead of NONE... well Null is not a NONE two different things 

;so    && PFAComments.DAG_BWVersion.GetValue() >= CMVers only get read if PFAComments not = to None

;if so its trying to get  DAG_BWVersion GlobalVariable property from a Null

;PFAComments.DAG_BWVersion.GetValue(),  by all counts that would be Unhandled exception and probably a CDT or

;shit gets locked down and craps all over your papyrus log with errors.

;GetFormFromFile returns a form or if not found a None !  if it functions as intended, So what happens when using this function 

;on game 1.5.97 or on something all these crazy AE updates broke since 1.5.97, not sure but, that what I meant to make sure VR is 

;compatible with it. As far I know it is based off 1.5.97 se game scripts and supposedly a great many functions and events stop 

;working for 1.5.97 after the AE updates. includeing OnPlayerLoadGame event, not sure about GetFormFromFile though..

 

Event OnSleepStop(bool abInterrupted)
    if  !Initialized
        Initialized = True
        PFAComments = Game.GetFormFromFile(0x0005BBE7, "Comment_Manager.esp") as CM_Comments
        if  PFAComments != None && PFAComments.DAG_BWVersion.GetValue() >= CMVers
            if  PFAComments.DAG_BWVersion.GetValue() > CMVers
                CMVers = PFAComments.DAG_BWVersion.GetValue()
                Create_MaleVariant(True)
            else
                Create_MaleVariant()
            endif            
            PFA_PafComments.SetValue(1)            
            Arousal = Game.GetFormFromFile(0x0003FC36, "SexLabAroused.esm") As Faction  ;for sextalk feature
            PFAComments.Set_FutaArmor(SOSKW, Futa)
        else
            ;Debug.Notification("Comment Manager not found!")
            PFA_PafComments.SetValue(0)
            PFAComments = None
            Arousal = None
        endif
        if  !(PlayerRef.HasSpell(PFA_PafCellTracker))
            PlayerRef.AddSpell(PFA_PafCellTracker)
        endif
        COBWSystems = Game.GetFormFromFile(0x0002912F, "Curses of the BloodWhore.esp") as BW_COBWSystems
        if  COBWSystems != None
            if  !COBW
                COBW = True
                BloodLust = COBWSystems.DAG_BloodWhore
                Debug.Notification("Curses of the BloodWhore found")
            endif
        else
            COBW = False
            COBWSystems = None
            BloodLust = None
            Debug.Notification("COBW not found")
        endif
        PFA_PafCellTrackerMarker.Moveto(PlayerRef)
        ND_TimeStamp = GameDaysPassed.GetValue()
        Debug.Notification("Paf Fixes and Addons initialized!")
        Return
    endif

   ;other stuff to do here if its already been Initialized

EndEvent

 

Finally got around to enabling papyrus logs, I see the log folder created and logs for some other items but no files generated for PFA or PAF. This was after loading PFA onto a fresh save where PAF was already initialized, having the MCM menu load for PFA (opening and closing the MCM quickly does do something for this, its not just you), toggling some settings, waiting a couple minutes, and sleeping to continued no effect. Reloaded to just before sleep to sleep again for good measure, same outcome and no logs.

 

Would an alternate start mod have any bearing on this? Just trying to rule out the differences in our experiences.

[Dg75]

On 7/8/2024 at 1:04 PM, Medieval Genie said:

On the newest versions of PAF Fixes and Addons (3.0.7) and PFA VoicePack (3.0.6), I got:

 

"Unhandled exception "EXCEPTION_ACCESS_VIOLATION" at 0x7FF71B982EC0 SkyrimSE.exe+1422EC0    mov eax, [rdi+0x28]"

I couldn't tell you what that is. 1422EC0 is memory address where it occurred. You need a log parser like Crash logger, or Net flix  script Framework if your 

on 1.5.97 as they can give a bit more details. 

 

If you are on Game 1.5.97, I can only recommend to update your game. PFA was created in CK v 1130 witch uses form 1.7 and and is not compatible

with 1.5.97 se and under. The Bees mod supposed to fix this, but maybe it don't ! 

I am on Skyrim 1.6.1170 the newest version and I have no issues ! And I cannot reproduce your crash.

 

Normally if had a CDT, I would pay very close attention to what is happening in game that led up to the moment of crash. 

This can tell you far more than rootin around in your memory address trying to figure out what 1422EC0 is.

E.g. When did it crash. On load ? or random ? or at specific moment and place ? Was a comment happening, Entering/exiting pfa tracked settlement ?

Paffing ? if so was player or follower ? On commode ? or pathing to one ? Accident ? ... walking about nude or stinky ?

The exact detail is their if you watch for it. Can you reproduce it ?

 

More than likely if PFA was a culprit, its probably because Your game version or system or something hates me !

No, their have been other reported similar issues, and most seem to be 1.5.97 users or VR witch I think is based off 1.5.97 se.

and seems to have occurred at 3.0.4 v update, when I implemented COBW. 

But then again you seem to have been having a lot of issues with PFA since its start.

 

I am not at all satisfied how COBW was implemented. That doesn't make it wrong, I used 3.0.7 vers without issue with and without COBW enabled.

But still PFA shouldn't need to listen for COBW at all, as it is a Master file to COBW.

COBW just wants to know PFA tracking system and when/what shit goes down.

I can easily handle this in PFA by creating Mod events, witch would also allow other mods to get on board.

So I have decided to Expunge COBW GetFormFromFile from PFA scripts all together and utilize Mod events instead.

I can also rid GetFormFromFile for Comment Manager and just make it a Masters requirement for PFA (I'll take a vote)

So maybe this will help you guys having issues or not! I don't know, but I think PFA will be better off.

 

[Dg75]

You should read the post above this one!

If anybody objects to this, Speak up or forever 🤢

Edited July 9, 2024 by Dg75

[emilHand]

44 minutes ago, Dg75 said:

I couldn't tell you what that is. 1422EC0 is memory address where it occurred. You need a log parser like Crash logger, or Net flix  script Framework if your 

on 1.5.97 as they can give a bit more details. 

 

If you are on Game 1.5.97, I can only recommend to update your game. PFA was created in CK v 1130 witch uses form 1.7 and and is not compatible

with 1.5.97 se and under. The Bees mod supposed to fix this, but maybe it don't ! 

I am on Skyrim 1.6.1170 the newest version and I have no issues ! And I cannot reproduce your crash.

 

Normally if had a CDT, I would pay very close attention to what is happening in game that led up to the moment of crash. 

This can tell you far more than rootin around in your memory address trying to figure out what 1422EC0 is.

E.g. When did it crash. On load ? or random ? or at specific moment and place ? Was a comment happening, Entering/exiting pfa tracked settlement ?

Paffing ? if so was player or follower ? On commode ? or pathing to one ? Accident ? ... walking about nude or stinky ?

The exact detail is their if you watch for it. Can you reproduce it ?

 

More than likely if PFA was a culprit, its probably because Your game version or system or something hates me !

No, their have been other reported similar issues, and most seem to be 1.5.97 users or VR witch I think is based off 1.5.97 se.

and seems to have occurred at 3.0.4 v update, when I implemented COBW. 

But then again you seem to have been having a lot of issues with PFA since its start.

 

I am not at all satisfied how COBW was implemented. That doesn't make it wrong, I used 3.0.7 vers without issue with and without COBW enabled.

But still PFA shouldn't need to listen for COBW at all, as it is a Master file to COBW.

COBW just wants to know PFA tracking system and when/what shit goes down.

I can easily handle this in PFA by creating Mod events, witch would also allow other mods to get on board.

So I have decided to Expunge COBW GetFormFromFile from PFA scripts all together and utilize Mod events instead.

I can also rid GetFormFromFile for Comment Manager and just make it a Masters requirement for PFA (I'll take a vote)

So maybe this will help you guys having issues or not! I don't know, but I think PFA will be better off.

 

 

Yeah VR being based on 1.5.97 SE is likely the culprit. I've tried I don't know how many different types of scenarios. It just won't play nice.

 

41 minutes ago, Dg75 said:

You should read the post above this one!

If anybody objects to this, Speak up or forever 🤢

 

I'm on board with whatever you think is best for stability, compatibility, option diversity, and most importantly sanity

 

But take care and don't work yourself too hard!

[snitch123]

Seems like a good idea and doesn't really complicate anything for the users of the mod in the end. Whatever makes it easier for you. 

Also I second that about the 1.5.97. I don't think BEES fully ports those parts of 1.6 backwards. At least it never really functioned for me when testing PFA. And I did use some other mods that required BEES so I know it worked otherwise. Updating to 1.6.+ literally fixed all of my issues and I did dig deeply into it while testing. 

 

Also I might be wrong but I believe VR version is based off of even older version than 1.5.97 , isn't it ?

Edited July 10, 2024 by snitch123

[emilHand]

1 hour ago, snitch123 said:

Seems like a good idea and doesn't really complicate anything for the users of the mod in the end. Whatever makes it easier for you. 

Also I second that about the 1.5.97. I don't think BEES fully ports those parts of 1.6 backwards. At least it never really functioned for me when testing PFA. And I did use some other mods that required BEES so I know it worked otherwise. Updating to 1.6.+ literally fixed all of my issues and I did dig deeply into it while testing. 

 

Also I might be wrong but I believe VR version is based off of even older version than 1.5.97 , isn't it ?

 

If I understand right, Skyrim VR's version number is 1.4.15 but that versioning is exclusive to the VR version. Its equivalent is SE 1.5.97.

[snitch123]

May have run into a minor issue. Seems on the new versions the notifications like "xxx needs to use the toilet" don't pop up. It's a bit of an issue with custom followers if you don't have a voice for them. Leads to some unexpected situations 😅

[Dg75]

On 7/13/2024 at 5:19 PM, snitch123 said:

May have run into a minor issue. Seems on the new versions the notifications like "xxx needs to use the toilet" don't pop up. It's a bit of an issue with custom followers if you don't have a voice for them. Leads to some unexpected situations 😅

Did they work on older version ?

Only the needs toilet notifications, the rest work ?

I'll take a look. I'm just finishing up 3.1.0, fixing to launch preliminary test

[Dg75]

12 minutes ago, Dg75 said:

Did they work on older version ?

Only the needs toilet notifications, the rest work ?

I'll take a look. I'm just finishing up 3.1.0, fixing to launch preliminary test

Yeah ! I dont think I had any notifications if needs toilet or accident, just comments.

Well I added them. so hopefully.. Getting ready to test this event system I added.

[snitch123]

1 hour ago, Dg75 said:

Did they work on older version ?

Only the needs toilet notifications, the rest work ?

I'll take a look. I'm just finishing up 3.1.0, fixing to launch preliminary test

Well I skipped a few versions as I haven't had much time to play.
3.0.4.7. still has the messages for me. No clue about any of the other version between that and the newest though.
Thanks for looking into that 👍

[Dg75]

PFA 3.1.0 is up.

Just removed GetFormFromFile calls for COBW and Comment manager.

Made PFA_VoicePackMain(Comment Manager.esp) a Masters. So it required now.

added Mod events for integration.

 

 

 

[emilHand]

12 hours ago, Dg75 said:

PFA 3.1.0 is up.

Just removed GetFormFromFile calls for COBW and Comment manager.

Made PFA_VoicePackMain(Comment Manager.esp) a Masters. So it required now.

added Mod events for integration.

 

 

 

 

I haven't gotten to test extensively but this new version loads for me without issue in VR. MCM menu popped up instantly and initialized after sleeping. Thanks!

[azunia]

What even is comment manager?

[Medieval Genie]

I need to get on here more frequently...
NO, it is NOT on VR or the old version of Skyrim.

 

The issue was starting since a couple of updates ago. I'll test which ones and I think at the time it was related to the .bsa file with the Comment Manager pack released at the same time. Crash to desktop on game load, yet curiously other save files which had never seen Pee And Fart before did not crash with it, it was specifically on the save slot(s) which had been using previous versions of Fixes And Addons.

[Dg75]

13 hours ago, azunia said:

What even is comment manager?

Oh just a comment mod pfa uses. It can be a framework for other mods to use as well.

In pfa's compatibility spoiler on main page is a link to Comment Manager mod page. Their in its downloads is a Modders resource 

with more intel on what it does as well as some How to instructions and examples.. Just don't use that Comment Manager mod for pfa.

PFA has its own version in its downloads, linked to mega. Their the same except for PFA'sVoice pack only comes with PFA's version.

[Dg75]

2 hours ago, Medieval Genie said:

I need to get on here more frequently...
NO, it is NOT on VR or the old version of Skyrim.

 

The issue was starting since a couple of updates ago. I'll test which ones and I think at the time it was related to the .bsa file with the Comment Manager pack released at the same time. Crash to desktop on game load, yet curiously other save files which had never seen Pee And Fart before did not crash with it, it was specifically on the save slot(s) which had been using previous versions of Fixes And Addons.

And this still happens with this PFA 3.1.0 update ?

I haven't had any issues loading the game, Not sure what would cause issues for only you. Maybe missing file ? 

If its a bsa thing I would think it cause issues for everybody, and Ive seen larger bsa's than PFA's.

 

Anyway let me know what you turn up, I will help anyway I can, if I can.