mod [mod] Human Cattle - Yet Another Milk Mod

[doop_lvl]

## New
- Added cattle owner column to restrict who can milk/breastfeed from lactator.

## Other Changes
- Added null check to post milking function to account where the milker is null.
- Removed annoying hand milk command float menu appearing on pawns that are not lactating.

[gimesi]

Hey, great mod i have been enjoying it but the last update somehow made all food inedible somehow for me, dont know if its an issue cause of my other mods but its an issue that somehow the new update created.

[doop_lvl]

1 hour ago, gimesi said:

Hey, great mod i have been enjoying it but the last update somehow made all food inedible somehow for me, dont know if its an issue cause of my other mods but its an issue that somehow the new update created.

im not sure whats happening, but you can download the most updated version on the gitgud here. i forgot to update the loverslab version, so its actually one update behind rn. sorry

[doop_lvl]

updated. the version here should now be synced with the gitgud version

[hereforsuperdays]

I got a lot of errors with the new update, found out its not working well with onahole anymore. I rolled back onahole to 3.1.1 version of onahole and it was still flooding with errors. I rolled Human Cattle back to an older version not sure which one. it didnt cause any problems with the trap statues though. It works now with the older version of human cattle thats 1.6 amd with the new version of onahole. 

 

P.S. love your mod, thank you for the continuous updates

 

Spoiler

Exception drawing OnaholeMetalFrame443432: System.NullReferenceException: Object reference not set to an instance of an object [Ref B1424641]   at HumanCattleOnahole.Patch_DrawGraphics.CalculateMilkingProgress (RJW_Onahole.Comps.CompMilkingMachine instance) [0x0002b] in :0   at HumanCattleOnahole.Patch_DrawGraphics.Prefix (RJW_Onahole.Comps.CompMilkingMachine __instance) [0x00001] in :0   at RJW_Onahole.Comps.CompMilkingMachine.DrawGraphics () [0x00000] in :0     - PREFIX Doop.HumanCattleOnahole: Void HumanCattleOnahole.Patch_DrawGraphics:Prefix(CompMilkingMachine __instance)   at RJW_Onahole.Comps.CompOnaholeBase.PostDraw () [0x0000f] in :0   at Verse.ThingWithComps.Comps_PostDraw () [0x00019] in :0   at Verse.ThingWithComps.DrawAt (UnityEngine.Vector3 drawLoc, System.Boolean flip) [0x00018] in :0   at Verse.Thing.DynamicDrawPhaseAt (Verse.DrawPhase phase, UnityEngine.Vector3 drawLoc, System.Boolean flip) [0x00004] in :0   at Verse.Thing.DynamicDrawPhase (Verse.DrawPhase phase) [0x00017] in :0   at Verse.DynamicDrawManager.DrawDynamicThings () [0x0011a] in :0     - POSTFIX net.pardeike.rimworld.mod.camera+: Void CameraPlus.DynamicDrawManager_DrawDynamicThings_Patch:Postfix() UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch1 (string) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.DynamicDrawManager.DrawDynamicThings_Patch1 (Verse.DynamicDrawManager) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Map.MapUpdate_Patch1 (Verse.Map) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.UpdatePlay_Patch1 (Verse.Game) Verse.Root_Play:Update ()

 

[doop_lvl]

5 hours ago, hereforsuperdays said:

I got a lot of errors with the new update, found out its not working well with onahole anymore. I rolled back onahole to 3.1.1 version of onahole and it was still flooding with errors. I rolled Human Cattle back to an older version not sure which one. it didnt cause any problems with the trap statues though. It works now with the older version of human cattle thats 1.6 amd with the new version of onahole. 

 

P.S. love your mod, thank you for the continuous updates

 

  Hide contents

Exception drawing OnaholeMetalFrame443432: System.NullReferenceException: Object reference not set to an instance of an object [Ref B1424641]   at HumanCattleOnahole.Patch_DrawGraphics.CalculateMilkingProgress (RJW_Onahole.Comps.CompMilkingMachine instance) [0x0002b] in :0   at HumanCattleOnahole.Patch_DrawGraphics.Prefix (RJW_Onahole.Comps.CompMilkingMachine __instance) [0x00001] in :0   at RJW_Onahole.Comps.CompMilkingMachine.DrawGraphics () [0x00000] in :0     - PREFIX Doop.HumanCattleOnahole: Void HumanCattleOnahole.Patch_DrawGraphics:Prefix(CompMilkingMachine __instance)   at RJW_Onahole.Comps.CompOnaholeBase.PostDraw () [0x0000f] in :0   at Verse.ThingWithComps.Comps_PostDraw () [0x00019] in :0   at Verse.ThingWithComps.DrawAt (UnityEngine.Vector3 drawLoc, System.Boolean flip) [0x00018] in :0   at Verse.Thing.DynamicDrawPhaseAt (Verse.DrawPhase phase, UnityEngine.Vector3 drawLoc, System.Boolean flip) [0x00004] in :0   at Verse.Thing.DynamicDrawPhase (Verse.DrawPhase phase) [0x00017] in :0   at Verse.DynamicDrawManager.DrawDynamicThings () [0x0011a] in :0     - POSTFIX net.pardeike.rimworld.mod.camera+: Void CameraPlus.DynamicDrawManager_DrawDynamicThings_Patch:Postfix() UnityEngine.StackTraceUtility:ExtractStackTrace () (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch1 (string) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.DynamicDrawManager.DrawDynamicThings_Patch1 (Verse.DynamicDrawManager) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Map.MapUpdate_Patch1 (Verse.Map) (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Game.UpdatePlay_Patch1 (Verse.Game) Verse.Root_Play:Update ()

 

ah sorry, i forgot to sync the loverslab version again. we had a merge request to fix this very issue, but i forgot to update it here. please download the most updated version from the gitgud for now. im used to manually updating both gitgud and this version at the same time, but since i have a collaborator working on onahole milking compat, im not used to updating this version whenever a merge request is accepted when said collaborator needed to make changes

[Skömer]

2 hours ago, doop_lvl said:

ah sorry, i forgot to sync the loverslab version again. we had a merge request to fix this very issue, but i forgot to update it here. please download the most updated version from the gitgud for now. im used to manually updating both gitgud and this version at the same time, but since i have a collaborator working on onahole milking compat, im not used to updating this version whenever a merge request is accepted when said collaborator needed to make changes

to always link to the latest version of the main branch of your mod just put https://gitgud.io/doop0707/human-cattle-yet-another-milk-mod/-/archive/master/human-cattle-yet-another-milk-mod-master.zip as the download on here

 

[doop_lvl]

i guess i can do that. i started publishing without gitgud. it never occurred to me i could just do that lol

[nothxnothx]

Hi, love the mod so far, but while progressing through at some point this one error message started displaying in the console persistently, every half a minute or so:

Error while notifying ideos of a HistoryEvent: System.ArgumentException: Could not find arg named VICTIM of type Pawn
[Ref F1E620A6]
  at RimWorld.SignalArgs.GetArg[T] (System.String name) [0x0002c] in <eeba28faf34b4733a85982df8e89f3eb>:0 
  at HumanCattle.PreceptComp_MemorySocialThought.Notify_MemberTookAction (RimWorld.HistoryEvent ev, RimWorld.Precept precept, System.Boolean canApplySelfTookThoughts) [0x0003b] in <83d0b9277ec64b47bd6b8a7d1bb972bd>:0 
  at RimWorld.Ideo.Notify_MemberTookAction (RimWorld.HistoryEvent ev, System.Boolean canApplySelfTookThoughts) [0x00031] in <eeba28faf34b4733a85982df8e89f3eb>:0 
  at RimWorld.IdeoUtility.Notify_HistoryEvent (RimWorld.HistoryEvent ev, System.Boolean canApplySelfTookThoughts) [0x00042] in <eeba28faf34b4733a85982df8e89f3eb>:0 
  at RimWorld.HistoryEventsManager.RecordEvent (RimWorld.HistoryEvent historyEvent, System.Boolean canApplySelfTookThoughts) [0x00000] in <eeba28faf34b4733a85982df8e89f3eb>:0 
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch1 (string)
RimWorld.HistoryEventsManager:RecordEvent (RimWorld.HistoryEvent,bool)
HumanCattle.Thing_PostIngested_Patch/PostIngested:Postfix (Verse.Pawn&,Verse.Thing)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Thing.PostIngested_Patch1 (Verse.Thing,Verse.Pawn)
Verse.ThingWithComps:PostIngested (Verse.Pawn)
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Thing.Ingested_Patch1 (Verse.Thing,Verse.Pawn,single)
RimWorld.Toils_Ingest/<>c__DisplayClass14_0:<FinalizeIngest>b__0 ()
Verse.AI.JobDriver:TryActuallyStartNextToil ()
Verse.AI.JobDriver:ReadyForNextToil ()
Verse.AI.JobDriver:DriverTick ()
Verse.AI.Pawn_JobTracker:JobTrackerTick ()
Verse.Pawn:Tick ()
Verse.Thing:DoTick ()
Verse.TickList:Tick ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.TickManager.DoSingleTick_Patch1 (Verse.TickManager)
Verse.TickManager:TickManagerUpdate ()
Verse.Game:UpdatePlay ()
Verse.Root_Play:Update ()

 

This is from a save, that I've introduced Human Cattle into, not a new save. I haven't tested if this happens in new saves or not, because this error appeared 8-12 hours of playtime in.

 

What I've tried to solve the issue:

-Elect a Human Cattle Specialist

-Put Human Cattle last in load order, but before mods that rely on it (Milk Based Drugs)

-Go through my mods and disable them on by one

-Disabled all other mods besides Human Cattle

 

So far nothing.

 

What is this VICTIM arg used by? Is it possible, that my custom (not modded) ideoligion is set up in a way that would cause this error?

[doop_lvl]

its possible your version is outdated. please try updating the mod

[BavianD]

Love the mod.

I noticed the item "Human Milk" and "Milk" has the same texture, and appears to be the same item, even though they don't stack. Cooking and crafting also seems to consider human milk regular milk. 

It seems to work out fine, besides the fact that it's difficult to separate Milk and Human Milk. I'm not sure if it's an issue with the mod, or intended.

Either way, great work!


 

Spoiler

 

Edited April 27 by BavianD

[doop_lvl]

if you look at the selected human milk, it will say "* directly produced by [someone]". this means that its still the vanilla milk item, but its label will have "human" appended to it because it was milked from a person. the asterisk also means that it can only stack together with the same item produced by the same pawn. Equal Milking has similar feature and i basically stole the concept from it, but i expanded it to include some opinions according to precept if someone consumes the milk and that human cattles have decreased hunger gain from eating the milk to make them not able to generate infinite milk drom nothing

[BavianD]

I see. I was confused by the fact that Human Milk had ingredients: 1x Human Milk with a different icon (which I assume is from Equal Milking).

I have a little feedback when it comes to Ex-Human Cattle, and the stuff related to Ideology. 

It's not immediately obvious as to how Human Cattle and Ex-Human Cattle are defined in the game, as the terms don't really correspond with the severity labels for the lactation and cattle conditioning hediffs. Currently the label "cattle" is for base lactation factor 1.4, followed by "enhanced cattle" at 1.7, and "at limit" at 2.0.
I think it would be more intuitive if the max severity for lactation was labeled "human cattle", instead of "at limit", so that it corresponded better with the description and conditions for the Human Cattle Rehabilitation ritual.

I understand that Ex-Human Cattle is a pawn that is at max lactation, and only at "self-aware" cattle conditioning, but it's not really obvious. Maybe "Ex-Human Cattle" could be added as it's own hediff, similar to "Cattle Blessing", to better indicate that a pawn is an ex-human cattle? Or would that mess with an ex-human cattle's ability to relapse into more severe cattle conditioning again?

Just some suggestions.

[doop_lvl]

i understand your concerns, and i find how these terminologies are somewhat divorced from the actual hediffs a bit frustrating too, but i unfortunately dont know a simple way to solve these problems. making another hediff just to clarify these labels will unfortunately only complicate things further as then you'll have another hediff that only functions as a label when hediffs usually affect the the pawn in some way. the better implementation is i guess by adding the descriptor somewhere in the lactating hediff's description

[nazeeeeem]

Great mod, but I have a question,

There's a milk amount defined in RJW by default, this mod doesn't seem to be taking that into account?

Referring to this:

[doop_lvl]

yeah, i forgot about that stat existing when i first build the system, and i havent switched to it because i dont know the random distribution of that stat to balance around it. i'd gladly switch the breast size factor into breast fluid instead if someone tell me the value i should balance it around

[nazeeeeem]

9 hours ago, doop_lvl said:

yeah, i forgot about that stat existing when i first build the system, and i havent switched to it because i dont know the random distribution of that stat to balance around it. i'd gladly switch the breast size factor into breast fluid instead if someone tell me the value i should balance it around

Here you go, seems like the average is around 20 and ranges from 10~40

https://gitgud.io/Ed86/rjw/-/blob/master/1.6/Source/Hediffs/HediffDef_SexPart.cs

[doop_lvl]

thanks for hunting down the part where fluid is calculated. unfortunately, looking at the code, it is apparent to me that its still not that simple. it appears fluids by default already take body size and the breast size into account in its calculation, so straight up replacing my breast factor to use fluid will make body size get calculated twice, as i have also included that factor in my own calculation while also having a better idea of how that calculation works. at the end of the day, the fluid calculation is just very obscured by its own calculation and im not sure how to balance it having its own body size and breast size calculation

[nazeeeeem]

3 hours ago, doop_lvl said:

thanks for hunting down the part where fluid is calculated. unfortunately, looking at the code, it is apparent to me that its still not that simple. it appears fluids by default already take body size and the breast size into account in its calculation, so straight up replacing my breast factor to use fluid will make body size get calculated twice, as i have also included that factor in my own calculation while also having a better idea of how that calculation works. at the end of the day, the fluid calculation is just very obscured by its own calculation and im not sure how to balance it having its own body size and breast size calculation

The obvious way would be to only use the bodysize/part size scaling from rjw, but if you don't want to redo the whole milk calculation i think you can just take the partFluidMultiplier from here as thats the stat most other mods' fluid change effects seem to affect

 

https://gitgud.io/Ed86/rjw/-/blob/master/1.6/Source/Comps/CompRJWThingBodyPart.cs

[doop_lvl]

ooh, that does seem like a promising method. i'll look into implementing it. i appreciate your suggestions!

[doop_lvl]

21 hours ago, nazeeeeem said:

The obvious way would be to only use the bodysize/part size scaling from rjw, but if you don't want to redo the whole milk calculation i think you can just take the partFluidMultiplier from here as thats the stat most other mods' fluid change effects seem to affect

this update now implements this

- Lactators with low lactation severity will now have their severity increased to mother stage and the milking timer reset the moment they give birth.
- Breast factor calculation for milk amount now take the breasts' fluid multiplier into account. This allows fluid multiplier altering effects such as galactagogue drug from Cumpilation mod to affect milk production, but milk production is now also subject to RJW's random range of breast fluid multiplier (from 0.75 to 1.25) upon generating the breast hediff.
- Fixed yellow warning on startup because a Texture2D is included in a class that doesn't have the StaticConstructorOnStartup attribute.

[BulBulOgly]

thanks for the mod! there is no transition to the next condition status after (needy).

[doop_lvl]

what do you mean by transition exactly?

[doop_lvl]

update

 

- Added new column in lactation tab showing progress to being unweaned.
- Pawns can now get the unweaned hediff if they have breastfed 5 times their food need (value can be changed in settings). The progress is shown in the new column. This progress slowly decrease without breastfeeding at least once every 1.5 days. You will get an event letter when a pawn gets unweaned.
- Right click to breastfeed someone to fill breastfeeding need can now self target.
- Pawn commanded to breastfeed themselves to fill breastfeed need now stop their pathing first.
- Pawns now only look for lactators to breastfeed from for every 250 ticks.
- Breastfeeding need now starts 90% full.

[camistrie]

Really want to give this mod a try (instead of Equal Milking), hoping for some features in order to make the jump:

- milk pipes, milking machines and milk fluid storage

- integration with onaholes extension for milking

TYVM!