XML Modding help wanted for removing stuff from RJW

[JaderII]

Hello everybody.

 

Not that new to LL and to RJW, but very new to modding. I tried to make a mod myself, removing things I personally dislike in RJW, but missing knowledge to remove them.

 

My most disliked feature are the Loading tips, followed by humpshroom. Finally, I wanted to remove the RJW-Toggle-Button in the bottom right, but my research showed, that I would need more than XMLs to tackle that. As well as Mod-Options, you need XML for that as well...

 

Anyway, my current patch looks like this:
 

<?xml version="1.0" encoding="utf-8"?>

<Patch>
<Operation Class="PatchOperationFindMod">
    <mods>
        <li>Rim Job World</li>
    </mods>
    <match Class="PatchOperationSequence">
    <operations>
    
    <li Class="PatchOperationRemove">
        <xpath>/Defs/TipSetDef[defName="RjwTips"]</xpath>
    </li>

    <li Class="PatchOperationRemove">
        <xpath>/Defs/ThingDef[defName="PlantHumpShroom"]</xpath>
    </li>

    <li Class="PatchOperationRemove">
        <xpath>/Defs/HediffDef[defName="HumpShroomEffect"]</xpath>
    </li>
    
    <li Class="PatchOperationRemove">
        <xpath>/Defs/ThoughtDef[defName="HumpShroomEffect"]</xpath>
    </li>
    
    <li Class="PatchOperationRemove">
        <xpath>/Defs/ChemicalDef[defName="HumpShroom"]</xpath>
    </li>
    
    <li Class="PatchOperationRemove">
        <xpath>/Defs/NeedDef[defName="Chemical_HumpShroom"]</xpath>
    </li>
    
    <li Class="PatchOperationRemove">
        <xpath>/Defs/HediffDef[defName="HumpShroomTolerance"]</xpath>
    </li>
    
    <li Class="PatchOperationRemove">
        <xpath>/Defs/HediffDef[defName="HumpShroomAddiction"]</xpath>
    </li>
    
    <li Class="PatchOperationRemove">
        <xpath>/Defs/ThoughtDef[defName="HumpShroomWithdrawal"]</xpath>
    </li>
	<-- This is probably never working, because I am not sure how to edit the costList correctly in order to remove the Humpshroom requirement and add a Herbal Medicine as a price -->
<--    <li Class="PatchOperationReplace">
        <xpath>/Defs/ThingDef[defName="RJW_FertPill"]/costList</xpath>
        <value>
        <costList>
            <MedicineHerbal>2</MedicineHerbal>
        </costList>
        </value>
    </li>
-->
    <li Class="PatchOperationRemove">
        <xpath>/Defs/ThingDef[defName="Aphrodisiac"]</xpath>
    </li>
    
    <li Class="PatchOperationRemove">
        <xpath>/Defs/ThingDef[defName="HumpShroom"]</xpath>
    </li>

    </operations>
    </match>
</Operation>
</Patch>

 

While the "Tips"-Part is working when its on its own... No of the other things seem to be working, even if alone. What am I missing in order to remove items? Help would be appreciated!

Have a nice day!

[Tory187]

Try using the mod Cherry Picker

[JaderII]

6 hours ago, Tory187 said:

Try using the mod Cherry Picker

Thank you for your answer!

 

I heard about the Mod Cherry Picker before, but never connected the obvious... I tried it, and it works for everything exept the tips, wich I can patch myself, so thank you very much!

The usage of cherry picker also showed me, that my testing-method for my mod was wrong - so I review my tries to get it working again.

 

Still trying to get behind the problems of my patch in order to learn more about mods, so if anybody sees something obviously wrong with my approach, I am greatfull for feedback

 

EDIT: I now found a solution... Instead of using a PatchSequence, I used individual Patches without checking for RJW, that made it work. I wish I knew, what the actual problem was, but at least I got two working solutions now. Thanks again for the recommendation of cherry picker

Edited September 3, 2022 by JaderII
News to progress

[Tory187]

yeah if one operation fails within a sequence the rest fails so it can be a bit of an unnecessary risk.