Milkable Colonists updated for 1.1

[OriginalNocare]

22 hours ago, onslort said:

@Rimworld419

 

I just tested with bionic breasts and it all worked as it should, so that isn't the problem.

 

I am having the same issue. I will attempt to figure out what the conflict is but my test so far indicate that it is breast specific. 
Test where on 4 diffrent races to make sure it wasn't race specific. Standard humans, mincho, rakkle, kurin.

Standard breasts and arcotech breasts work fine.
However, bionic breasts, slime breasts, and hydraulic breasts all fail by sitting at Milk fullness: 0% (Bottles: 0).

If I add multiple pairs of breasts of diffrent kinds the ones that work add bottle totals together as expected but the ones that don't work have no effect on the total but also don't break the working set.

 

[onslort]

@Rimworld419
@OriginalNocare

It does sound like there is a mod installed that is making what it considers 'non milk making breasts' to not make milk.

 

I checked out RJW_menstruation and it was fine.

 

After taking a look down the list of mods on the main RJW post the only other one that looked like it might change body parts was RJW RBSE Integration but that doesn't appear to have anything that changes the bionic breasts.

 

This is my test list of mods (shorter for faster loading) with working bionic breasts:

 

My guess is one of the RJW mods that you have that I do not have is the culprit here for you. It will just be a matter of narrowing down which one.

 

If it's not a RJW mod, another possibility might be a mechanoid or android race mod?

[Miia]

On 2/15/2023 at 12:04 AM, onslort said:

Induce lactation by default will take 7 days of massages before the pawn will start lactating. Coffee's original thoughts there were it's free but it takes time to balance that out. I also added in an options page so you can change the amount of work needed, lowering values will make the target pawns start lactating sooner.

This entire section of your response is completely irrelevant to me, the game isnt even giving me the option of inducing lactation that way, there is absolutely nothing about it showing up in game the way it did in 1.3

[rimworld419]

@onslort

here is the list of RJW mods I have

 

[OriginalNocare]

@onslort

Well the problem is not a mod conflict. I removed all mods except the those required to run the minimum test.
I even removed RJW and installed it fresh. 

The same result as before. 
The breasts, generic breasts, arcotech breasts work.
Others don't.

Based on the last updated/edited
I have RJW from Dec 18, 2022
RJW-MC-Biotech from Dec 29, 2022

Edited February 18, 2023 by OriginalNocare

[onslort]

Huh.  I wonder do I have a mod that enabled those bodyparts, rather than it being the other way around.

 

I'll do some digging.

 

 

[onslort]

Turns out my tests were bad. I took a pawn that had regular breasts and swapped out the hediff for hydraulic breasts.  For whatever reason, that allowed the pawn to continue producing milk as normal and so I thought it was working.

 

I started a new game with a pawn with hydraulic breasts from the start and I'm see the same thing with the breasts not producing milk even if you feed them lact-x. Theyget the lactating hediff but not the biotech hediff, and they stay at 0% and 0 bottles.

 

I'll investigate further to see if I can track down where this is happening.

[onslort]

Hah!

 

Turns out it's the Milkable Colonists mod.

 

It looks like only Archotech Breasts were given a fluid type. Probably a decision from the original creator of the mod before I started tweaking it.

 

I'll update it to prevent lost time and confusion in future.

 

 

[onslort]

@Miia
 

The Induce lactation option comes from C0ffee's Ideology addons mod. You'll have to make sure to download the compatible version from here and have it running.

 

Next you'll need to make your ideology have the hucow meme. You may have to start a new colony if you don't know how to dev-mode update your existing ideology.

 

Then you'll need to have a hucow handler in your colony. You can assign someone the job at your altar/symbol/whatever your ideology uses to change pawns social position.

 

The hucow handler should have options when selected:

 

If you are sure you have the latest versions installed and your hucow handler still doesn't show these options then it may a mod conflict.

 

I think this should all work without biotech, but I don't know for certain.

 

[Miia]

9 minutes ago, onslort said:

Next you'll need to make your ideology have the hucow meme

So that's why, a weird change that makes no sense.

[onslort]

I'm not sure when that changed, I didn't change it.  I just put some tweaks to make it compatible with my updated copy of MC, and added some options.

 

And I can see it making sense from the perspective of the mod. The hucow handler is the specialist that can change pawns to hucows and induce lactation in them.  Others aren't specialized in doing so, but you can still use the drugs to induce lactation instead.

 

 

[onslort]

Mod update!

 

It's been a while. Blame steam sales. (And I still have to finish Midnight Suns)

 

Added a new option that will prevent most jobs from being interrupted when someone milks or breastfeeds from the target pawn.  If the pawn is sleeping, moving or not doing anything important the pawn will stop and be involved with the milking/breastfeeding, otherwise they will keep on doing whatever they were doing.

 

It probably goes something like this: "You're researching? You're looking a bit full, let me milk you. Carry on working on your schematics."

 

It may make less sense for more physical jobs like mining. I'm still tweaking it.

 

Also updated hydraulic and bionic breasts to give milk. I'll probably add in an option to toggle this given time so people can choose what they think should be right. For now it will be turned on.

 

Convenient link to download post

 

 

[onslort]

@Rimworld419
@OriginalNocare

 

I just posted a new version of the mod which adds milk to the hydraulic and bionic breasts.

 

It likely won't work straight away however for existing pawns.

 

<Edit for simpler steps I just found>

 

If your pawn already has the lactating hediff, adjust the severity of the breast hediff in dev mode and after doing this I would get a log message that the hediff broke and it was resetting, and then it started working and the pawn started producing milk.  This was only needed for existing pawns with broken breasts.

 

If they don't have the lactating hediff give them some lact-x and then adjust the severity of the breast hediff.  This should only have to be done once and they should be good to go.

 

Edited February 18, 2023 by onslort

[Miia]

1 hour ago, onslort said:

I'm not sure when that changed, I didn't change it.  I just put some tweaks to make it compatible with my updated copy of MC, and added some options.

 

And I can see it making sense from the perspective of the mod. The hucow handler is the specialist that can change pawns to hucows and induce lactation in them.  Others aren't specialized in doing so, but you can still use the drugs to induce lactation instead.

 

 

It would make sense for a specialist to be better at inducing lactation, but it doesn't make sense for doing so without drugs to be limited to specialists.

[OriginalNocare]

@onslort

Thanks for the fix, works fine now. Definitely had to fiddle with it for a sec to start but it did start.
I will report if any new bugs got introduced.

Is the fix in the def files or in the compiled code.
I have visual studio setup to do changes but that takes more motivation to go digging thru to find the stuff.

Reason being I wanted to make other breast types also work. I don't have race support on currently cause it was complaining about compatibility so I can't test the large list, only slime breasts. but they don't work.
I am totally willing to add it myself.

[onslort]

Wait. I feel completely insane and just realized that the changes I made were in the base RJW files.

 

I wonder is it pure luck that those steps made it work for you? Possibly related to your own adding, removing and re-adding of hediffs?

 

Regardless. For educational purposes the file I changed was in the main RJW mod folder, in:

 

1.4\Defs\HediffDefs\Hediffs_PrivateParts

And look for the file:

Hediffs_PrivateParts_Implants.xml

 

You'll find that ArchotechBreasts has this line:

        <FluidType>Milk</FluidType>

 

Which the other breast entries, HydraulicBreasts and BionicBreasts don't have any FluidType.  You can copy and paste
        <FluidType>Milk</FluidType>
And add it to both of those so that they will have 'milk' by default. (For now.)

 

For the slime breasts, in the same folder is a file named:

Hediffs_PrivateParts_Slime.xml

 

In the file, the entry SlimeBreasts has an empty fluid type entry:

        <FluidType></FluidType>

 

You could add Milk into there, or another fluid ID. I'm not sure offhand if it will work nicely with other fluids.

 

I guess it was pure luck that those steps worked for you to get the counter started.

 

I'll update the Milkable Colonists mod and put actual overrides into there rather than me adjusting files in another mod and thinking it should work for mine.  (No idea what I was thinking there.)

 

I also want to put in sliders for the percentage of milk that those artificial breasts will give as well so people can choose if they should make the same milk, less milk or none. I'll make sure I put the changes into the right place this time.

 

I'm probably only going to do this for the artificial breasts. You should adjust the slime breasts to do what you want them to do.

 

 

[onslort]

Mod update: Ver 011b.

 

Actually updated Hydraulic and Bionic breasts to give milk. (For real this time.) In base RJW Hydraulic and Bionic breasts give no milk. These are now being patched in Milkable Colonists so they will.

 

Also added some code tweaks to go along with this. The amount of milk the artificial breasts hold is different compared to natural breasts.

Default values:

Hydraulic breasts will give 50% the amount vs natural breasts of the same size.

Bionic breasts will give 75% the amount vs natural breasts of the same size.

Archotech breasts will give 125% the amount vs natural breasts of the same size.

These amounts can all be adjusted in the options.

 

Convenient link to download post

 

[Salacian]

Oh, could we get the git updated? it's nice for auto updaters, downloading and extracting a file each time there is an update for every individual mod is a chore

[rimworld419]

Last update fixed my broken pawns. Thank you!

[Ledronas]

Question im working on a Biopod that would milk colonist automatically. What would i need to do to make it work with this mod.  this will be a fixed station to put prisoner pawns in to convert to hucow for Coffee ideology meme so they always have milk but I want it to be balanced where it only produces what the pawn can. 

[Akaluto]

6 hours ago, Ledronas said:

Вопрос: Я работаю над биоподом, который будет автоматически подоить колониста. Что мне нужно сделать, чтобы заставить его работать с этим модом. это будет стационарная станция для размещения пешек-заключенных для преобразования в хукоу для мема идеологии кофе, чтобы у них всегда было молоко, но я хочу, чтобы она была сбалансирована, где она производит только то, что пешка может. 

Looks like something that should be flashing, not just milking, don't you think it's Brobdingnag?
I think a pillory version would also be appropriate, for tribal and non-space technologies, what do you think?

[Ledronas]

7 hours ago, Akaluto said:

Looks like something that should be flashing, not just milking, don't you think it's Brobdingnag?
I think a pillory version would also be appropriate, for tribal and non-space technologies, what do you think?

Exactly my thoughts i was going to make both for people to have the ability to use it in any playthrough. though i first need an idea of how to link it. right now all my mod does right now is you put a prisoner or slave into the pod and every 2.5 or so days it makes 5 milk atm 

[onslort]

@Ledronas

 

I've never setup a structure before, but I'm guessing it would be similar to pawn on pawn interactions.  The structure probably gets a workgiver setup, and assigns jobs out to appropriate pawns.

 

If you look in the Milkable colonist code in the JobsAndWork folder there are workgiver setups for a couple of the milking tasks, and jobs to go along with them.

 

You can check the CompMilkableHuman comp, I've tried to make the values easy to get a hold of.  The workgiver checks comp.Active and comp.BottleCount or comp.Fullness, you could check these as well to see if a pawn has milk to give.

 

The MilkSelf or MilkHuman jobdrivers might give decent examples of milking bottles. They assign a long work time but there is a shorter tick timer where the will spawn a bottle of milk and remove a bottle of milk from the pawn's comp at the same time.

[Ledronas]

6 hours ago, onslort said:

@Ledronas

 

I've never setup a structure before, but I'm guessing it would be similar to pawn on pawn interactions.  The structure probably gets a workgiver setup, and assigns jobs out to appropriate pawns.

 

If you look in the Milkable colonist code in the JobsAndWork folder there are workgiver setups for a couple of the milking tasks, and jobs to go along with them.

 

You can check the CompMilkableHuman comp, I've tried to make the values easy to get a hold of.  The workgiver checks comp.Active and comp.BottleCount or comp.Fullness, you could check these as well to see if a pawn has milk to give.

 

The MilkSelf or MilkHuman jobdrivers might give decent examples of milking bottles. They assign a long work time but there is a shorter tick timer where the will spawn a bottle of milk and remove a bottle of milk from the pawn's comp at the same time.

Thank you i will take a look into that! 

[Hawk32]

Hey there.

 

Couple of observations after playing with the mod for a while.

 

First off changing the milk rate in the options doesn't appear to actually change the total job time at all. The milk gets extracted faster for sure but overall tick length of the entire job seems to last the same regardless if all the milk is extracted halfway through the job being complete which causes some of the jobs to either end prematurely or end up with the pawns standing around doing nothing.

 

This seems to be very noticeable with the self milk job. The pawns will often milk themselves and then stand around for an extended period. The breastfeeding job doesn't seem to have this problem the baby feeding as well so that seems to work more or less correctly.

 

Also I had a question regarding the milking job. I wanted to extend the ability to certain animal colonists (Kyulen) so I went into the mod and disabled the humanlike checks on the various jobs and was able to get them to breastfeed correctly. The milking job however breaks pretty badly causing a 10jobs in 10 ticks error. Something about the job seems to break when trying to target an animal.

 

I'm wondering if you might have any insight as to what might cause the job to break. I've speculated it might have something to do with not being able to reserve the target or possibly the removing clothes aspect. 

 

Sadly I'm just barely able to understand the code and make very minor changes the specific details on how targeting etc are beyond me.